Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move rust/decentraland-godot-lib to lib and rust/xtask to root #428

Merged
merged 10 commits into from
Jun 23, 2024
Merged

refactor: move rust/decentraland-godot-lib to lib and rust/xtask to root #428

merged 10 commits into from
Jun 23, 2024

Conversation

leanmendoza
Copy link
Collaborator

@leanmendoza leanmendoza commented Jun 21, 2024 •
edited by kuruk-mm
Loading

What ?

  • move rust/decentraland-godot-lib to lib
  • move rust/xtask to root folder
  • rename decentraland-godot-lib to dclgodot
  • godot version showed when it opens, 0.1.0-commitXXXXXXXXXXXX and it fallbacks to 0.1.0-timestampXXXXXXX if the repo is not safe

TODO

@leanmendoza leanmendoza changed the title wip reorg refactor: move rust/decentralalnd-godot-lib to lib and rust/xtask to root Jun 22, 2024
@leanmendoza leanmendoza changed the title refactor: move rust/decentralalnd-godot-lib to lib and rust/xtask to root refactor: move rust/decentraland-godot-lib to lib and rust/xtask to root Jun 22, 2024
@leanmendoza leanmendoza marked this pull request as ready for review June 22, 2024 01:13
kuruk-mm
kuruk-mm approved these changes Jun 23, 2024
View reviewed changes
Copy link
Member

@kuruk-mm kuruk-mm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is great!

@leanmendoza leanmendoza merged commit 43a962a into main Jun 23, 2024
3 checks passed
@leanmendoza leanmendoza deleted the refactor/reorg-repo branch June 23, 2024 00:33
kuruk-mm added a commit that referenced this pull request Jun 24, 2024
@leanmendoza @kuruk-mm
refactor: move rust/decentraland-godot-lib to lib and `rust/xtask…
d0c93c2 
…` to root (#428)

* wip reorg

* wip

* test

* fix export

* fix versioning?

* reverting main.gd

* add version to first log

* restore ci

* update readme and bump version

* fixes

---------

Co-authored-by: Mateo "Kuruk" Miccino <mateomiccino@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuruk-mm kuruk-mm kuruk-mm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leanmendoza @kuruk-mm