Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: basic VR implementation #442

Merged
merged 26 commits into from
Sep 19, 2024
Merged

feat: basic VR implementation #442

merged 26 commits into from
Sep 19, 2024

Conversation

kuruk-mm
Copy link
Member

@kuruk-mm kuruk-mm commented Aug 19, 2024 •
edited
Loading

Superseed #384
Closes #277

  • Godot Explorer now works in VR
  • Remove VR assets on non-VR exports
  • Seemless usage on Desktop / Mobile / VR
  • Loading follows screen
  • Lobby follows screen
  • Main menu follows screen
  • Add Quests build to the CI
  • Fix bug: your own Avatar were being shown even if you're in first person after you change the parcel

Missing:

  • Show/hide Game UI on the World
  • World raycast from right hand instead of the camera (where are you looking at)

Future: #445

@kuruk-mm kuruk-mm marked this pull request as draft August 19, 2024 11:59
@kuruk-mm kuruk-mm marked this pull request as ready for review September 19, 2024 00:30
@kuruk-mm kuruk-mm changed the title feat: VR feat: basic VR implementation Sep 19, 2024
leanmendoza
leanmendoza requested changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@leanmendoza leanmendoza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work 😄
Minor comments and question

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.godot/uid_cache.bin Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this should be pushed :)

godot/.godot/extension_list.cfg Show resolved Hide resolved
godot/assets/environment/sky_base.gd Outdated Show resolved Hide resolved
godot/export_presets.cfg Outdated Show resolved Hide resolved
godot/export_presets.cfg Show resolved Hide resolved
godot/export_presets.cfg Outdated Show resolved Hide resolved
godot/src/config/config_data.gd Show resolved Hide resolved
godot/src/decentraland_components/avatar/avatar.gd Outdated Show resolved Hide resolved
godot/src/ui/ui.gd Outdated Show resolved Hide resolved
@kuruk-mm kuruk-mm merged commit 46384e8 into main Sep 19, 2024
3 checks passed
@kuruk-mm kuruk-mm deleted the feat/vr-2 branch September 19, 2024 17:17
@kuruk-mm kuruk-mm mentioned this pull request Sep 19, 2024
Closed
@kuruk-mm kuruk-mm mentioned this pull request Oct 17, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leanmendoza leanmendoza leanmendoza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create VR CI Pipeline
2 participants
@kuruk-mm @leanmendoza