Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add search input for worlds #448

Merged
merged 4 commits into from
Sep 20, 2024
Merged

feat: add search input for worlds #448

merged 4 commits into from
Sep 20, 2024

Conversation

leanmendoza
Copy link
Collaborator

@leanmendoza leanmendoza commented Sep 20, 2024 •
edited
Loading

search-discover

  • chore: update imports

Also:

  • add spinner when items are reset and start loading again
  • add spinner when you scroll and it's fetching new items.
  • add a message when there are no results
  • add a message if there was an error

@kuruk-mm kuruk-mm merged commit 9833e3b into main Sep 20, 2024
3 checks passed
@kuruk-mm kuruk-mm deleted the feat/add-worlds-search branch September 20, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuruk-mm kuruk-mm kuruk-mm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leanmendoza @kuruk-mm