Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement websocket #45

Merged
merged 8 commits into from
Sep 18, 2023
Merged

feat: implement websocket #45

merged 8 commits into from
Sep 18, 2023

Conversation

leanmendoza
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2023

Codecov Report

Patch coverage: 7.10% and project coverage change: -1.28% ⚠️

Comparison is base (9bbb32b) 19.49% compared to head (3ca4757) 18.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
- Coverage   19.49%   18.22%   -1.28%     
==========================================
  Files          58       59       +1     
  Lines        6790     7299     +509     
==========================================
+ Hits         1324     1330       +6     
- Misses       5466     5969     +503     
Files Changed Coverage Δ
rust/decentraland-godot-lib/src/av/ffmpeg_util.rs 0.00% <0.00%> (ø)
...ust/decentraland-godot-lib/src/av/video_context.rs 0.00% <0.00%> (ø)
rust/decentraland-godot-lib/src/av/video_stream.rs 0.00% <0.00%> (ø)
...aland-godot-lib/src/comms/communication_manager.rs 1.14% <0.00%> (ø)
rust/decentraland-godot-lib/src/comms/wallet.rs 0.00% <0.00%> (ø)
rust/decentraland-godot-lib/src/comms/ws_room.rs 0.00% <0.00%> (ø)
...ust/decentraland-godot-lib/src/dcl/crdt/message.rs 0.00% <0.00%> (ø)
rust/decentraland-godot-lib/src/dcl/js/mod.rs 0.00% <0.00%> (ø)
...decentraland-godot-lib/src/dcl/js/websocket/mod.rs 0.00% <0.00%> (ø)
...ot-lib/src/scene_runner/components/avatar_shape.rs 0.00% <0.00%> (ø)
... and 13 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kuruk-mm kuruk-mm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the current SceneRuntime, the Explorer should only allows wss://. It would be great to maintain that limitation to have the same behaviour on all platforms (we should do the same for fetch, too).

Another thing that we can add later is the permissions for using WebSocket that are in the scene.json. I want to add a TODO for that.

rust/decentraland-godot-lib/src/dcl/js/js_modules/ws.js Outdated Show resolved Hide resolved
rust/decentraland-godot-lib/src/dcl/js/js_modules/ws.js Outdated Show resolved Hide resolved
@leanmendoza
Copy link
Collaborator Author

According to the current SceneRuntime, the Explorer should only allows wss://. It would be great to maintain that limitation to have the same behaviour on all platforms (we should do the same for fetch, too).

Another thing that we can add later is the permissions for using WebSocket that are in the scene.json. I want to add a TODO for that.

Thanks for the review. Nice catch, we're going to document that extra part of the runtime.

kuruk-mm
kuruk-mm previously approved these changes Sep 15, 2023
@leanmendoza leanmendoza merged commit 54760ca into main Sep 18, 2023
3 checks passed
@leanmendoza leanmendoza deleted the feat/implement-websocket branch September 18, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants