Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add signed fetch #49

Merged
merged 7 commits into from
Sep 26, 2023
Merged

feat: add signed fetch #49

merged 7 commits into from
Sep 26, 2023

Conversation

kuruk-mm
Copy link
Member

@kuruk-mm kuruk-mm commented Sep 24, 2023

Note: It's initializing a new wallet for the scenes, that means that the comms and the scene sign will be different.

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2023

Codecov Report

Attention: 57 lines in your changes are missing coverage. Please review.

Comparison is base (9cd4af8) 16.97% compared to head (7f87f34) 16.65%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
- Coverage   16.97%   16.65%   -0.32%     
==========================================
  Files          61       62       +1     
  Lines        7837     7985     +148     
==========================================
  Hits         1330     1330              
- Misses       6507     6655     +148     
Files Coverage Δ
rust/decentraland-godot-lib/src/comms/livekit.rs 0.00% <ø> (ø)
...t/decentraland-godot-lib/src/comms/signed_login.rs 0.00% <ø> (ø)
rust/decentraland-godot-lib/src/comms/ws_room.rs 0.00% <ø> (ø)
rust/decentraland-godot-lib/src/lib.rs 47.36% <ø> (ø)
...ecentraland-godot-lib/src/comms/player_identity.rs 0.00% <0.00%> (ø)
rust/decentraland-godot-lib/src/dcl/mod.rs 29.41% <0.00%> (-5.08%) ⬇️
...ust/decentraland-godot-lib/src/dcl/js/fetch/mod.rs 0.00% <0.00%> (ø)
...raland-godot-lib/src/scene_runner/scene_manager.rs 0.35% <0.00%> (-0.05%) ⬇️
rust/decentraland-godot-lib/src/dcl/js/mod.rs 0.00% <0.00%> (ø)
rust/decentraland-godot-lib/src/wallet/mod.rs 0.00% <0.00%> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kuruk-mm kuruk-mm marked this pull request as ready for review September 25, 2023 17:33
@leanmendoza leanmendoza marked this pull request as draft September 25, 2023 20:38
@kuruk-mm kuruk-mm force-pushed the feat/add-signed-fetch branch from f011571 to 7f87f34 Compare September 26, 2023 20:41
@kuruk-mm kuruk-mm marked this pull request as ready for review September 26, 2023 20:43
@leanmendoza leanmendoza merged commit 7a53cd6 into main Sep 26, 2023
@leanmendoza leanmendoza deleted the feat/add-signed-fetch branch September 26, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants