Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: animator, player transform, audio source out of the scene and TextShape align #491

Merged
merged 3 commits into from
Nov 13, 2024
Merged

fix: animator, player transform, audio source out of the scene and TextShape align #491

merged 3 commits into from
Nov 13, 2024

Conversation

leanmendoza
Copy link
Collaborator

@leanmendoza leanmendoza commented Nov 13, 2024 •
edited
Loading

What?

  • fix: animator controller regression
  • fix: player.avatar for calculate PlayerEntity transform
  • fix: TextShape size not dismissed for non wrapping ones
  • fix: audio source still plays with the player out of the scene

@leanmendoza
fix: animator controller regression
2c3e81d 
fix: player.avatar for calculate PlayerEntity transform
fix: TextShape size not dismissed for non wrapping ones
@leanmendoza leanmendoza enabled auto-merge (squash) November 13, 2024 01:35
@leanmendoza leanmendoza disabled auto-merge November 13, 2024 01:35
@leanmendoza leanmendoza enabled auto-merge (squash) November 13, 2024 01:36
@leanmendoza
fix: player node reference
adce21e 
fix: AudioSource not updating volume_db until it's moving
@leanmendoza leanmendoza changed the title fix: animator, player transform and TextShape align fix: animator, player transform, audio source out of the scene and TextShape align Nov 13, 2024
@leanmendoza leanmendoza disabled auto-merge November 13, 2024 11:54
@leanmendoza leanmendoza enabled auto-merge (squash) November 13, 2024 11:54
@leanmendoza leanmendoza merged commit a4a494a into main Nov 13, 2024
7 checks passed
@leanmendoza leanmendoza deleted the fix/animation-and-textshape branch November 13, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuruk-mm kuruk-mm kuruk-mm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leanmendoza @kuruk-mm