Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add visibility component and camera component #57

Merged
merged 7 commits into from
Oct 11, 2023

Conversation

kuruk-mm
Copy link
Member

@kuruk-mm kuruk-mm commented Oct 9, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (feb2fef) 16.49% compared to head (72f0eed) 16.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
- Coverage   16.49%   16.46%   -0.04%     
==========================================
  Files          63       64       +1     
  Lines        8170     8187      +17     
==========================================
  Hits         1348     1348              
- Misses       6822     6839      +17     
Files Coverage Δ
...traland-godot-lib/src/scene_runner/update_scene.rs 0.00% <0.00%> (ø)
...odot-lib/src/scene_runner/components/visibility.rs 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kuruk-mm kuruk-mm changed the title feat: add visibility component feat: add visibility component and camera component Oct 10, 2023
leanmendoza
leanmendoza previously approved these changes Oct 11, 2023
Copy link
Collaborator

@leanmendoza leanmendoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! only one change with where compare the current camera mode

@kuruk-mm kuruk-mm merged commit e35a264 into main Oct 11, 2023
@kuruk-mm kuruk-mm deleted the feat/add-components branch October 11, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants