-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add scenes rpcs thought tokio oneshot channels and change realm for restricted action api #62
Conversation
…ad), now it triggers the overlapping correctly
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
==========================================
- Coverage 16.10% 15.75% -0.36%
==========================================
Files 70 75 +5
Lines 8555 8767 +212
==========================================
+ Hits 1378 1381 +3
- Misses 7177 7386 +209
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The RPC implementation is good, I'm not really sure about setting callbacks for the answers, maybe use directly with channels?
rust/decentraland-godot-lib/src/dcl/js/js_modules/RestrictedActions.js
Outdated
Show resolved
Hide resolved
…tions.js Co-authored-by: Lean Mendoza <leandro@decentraland.org> Signed-off-by: Mateo Miccino <mateo@decentraland.org>
Extra BugFix for CameraModeArea: when you unload the scene while you're in a CameraModeArea, it triggers the exit of the area.