Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add scenes rpcs thought tokio oneshot channels and change realm for restricted action api #62

Merged
merged 6 commits into from
Oct 18, 2023

Conversation

kuruk-mm
Copy link
Member

@kuruk-mm kuruk-mm commented Oct 15, 2023

Extra BugFix for CameraModeArea: when you unload the scene while you're in a CameraModeArea, it triggers the exit of the area.

@kuruk-mm kuruk-mm changed the title Feat/add rpcs and restricted action feat: add scenes rpcs thought tokio oneshot channels and restricted action Oct 15, 2023
@kuruk-mm kuruk-mm marked this pull request as draft October 15, 2023 20:02
@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2023

Codecov Report

Attention: 227 lines in your changes are missing coverage. Please review.

Comparison is base (b613e04) 16.10% compared to head (734e00e) 15.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
- Coverage   16.10%   15.75%   -0.36%     
==========================================
  Files          70       75       +5     
  Lines        8555     8767     +212     
==========================================
+ Hits         1378     1381       +3     
- Misses       7177     7386     +209     
Files Coverage Δ
rust/decentraland-godot-lib/src/dcl/mod.rs 28.98% <ø> (-0.43%) ⬇️
rust/decentraland-godot-lib/src/lib.rs 46.15% <ø> (-1.22%) ⬇️
...t/decentraland-godot-lib/src/scene_runner/scene.rs 21.80% <20.00%> (-0.17%) ⬇️
...raland-godot-lib/src/scene_runner/rpc_calls/mod.rs 0.00% <0.00%> (ø)
...traland-godot-lib/src/scene_runner/update_scene.rs 0.00% <0.00%> (ø)
rust/decentraland-godot-lib/src/dcl/js/engine.rs 0.00% <0.00%> (ø)
rust/decentraland-godot-lib/src/dcl/js/mod.rs 0.00% <0.00%> (ø)
...raland-godot-lib/src/scene_runner/scene_manager.rs 0.35% <0.00%> (+<0.01%) ⬆️
rust/decentraland-godot-lib/src/common/rpc.rs 0.00% <0.00%> (ø)
...traland-godot-lib/src/dcl/js/restricted_actions.rs 0.00% <0.00%> (ø)
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kuruk-mm kuruk-mm changed the title feat: add scenes rpcs thought tokio oneshot channels and restricted action feat: add scenes rpcs thought tokio oneshot channels and change realm for restricted action api Oct 16, 2023
@kuruk-mm kuruk-mm requested a review from leanmendoza October 16, 2023 01:28
@kuruk-mm kuruk-mm marked this pull request as ready for review October 16, 2023 01:28
Copy link
Collaborator

@leanmendoza leanmendoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RPC implementation is good, I'm not really sure about setting callbacks for the answers, maybe use directly with channels?

…tions.js

Co-authored-by: Lean Mendoza <leandro@decentraland.org>
Signed-off-by: Mateo Miccino <mateo@decentraland.org>
@kuruk-mm kuruk-mm merged commit e3e68ed into main Oct 18, 2023
@kuruk-mm kuruk-mm deleted the feat/add-rpcs-and-restricted-action branch October 18, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants