Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ui for scenes #65

Merged
merged 14 commits into from
Oct 26, 2023
Merged

feat: ui for scenes #65

merged 14 commits into from
Oct 26, 2023

Conversation

leanmendoza
Copy link
Collaborator

@leanmendoza leanmendoza commented Oct 23, 2023

Implement UI system for scenes

Imagen de WhatsApp 2023-10-25 a las 15 10 03_6693afb8

TODO list

  • basic UiTransform
  • basic UiBackground => color, nine slices, center and stretch mode
  • basic UiText
  • hide scene UI when is not current parcel scene nor global
    • define mechanism => only hide and keep computing, hide and stop computing (maybe save the dirties)
      • the root ui node is removed from the main scene tree, the ui doesn't receive any update until is added again. when the root scene ui node is added, all the dirty entities components are processed (except those were deleted)
  • implement overflow visible and hidden
  • UiText set font
  • clean code

scroll deferred

To be implemented in other PR:

  • VideoTexture for UiBackground
  • AvatarTexture for UiBackground and Material
  • UiDropdown
  • UiInput
  • PointerEvents

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2023

Codecov Report

Attention: 1079 lines in your changes are missing coverage. Please review.

Comparison is base (60e2fc8) 15.13% compared to head (a4535f0) 13.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
- Coverage   15.13%   13.98%   -1.15%     
==========================================
  Files          78       85       +7     
  Lines        9173    10169     +996     
==========================================
+ Hits         1388     1422      +34     
- Misses       7785     8747     +962     
Files Coverage Δ
...godot-lib/src/scene_runner/components/billboard.rs 85.71% <100.00%> (-14.29%) ⬇️
...cene_runner/rpc_calls/handle_restricted_actions.rs 0.00% <0.00%> (ø)
...-lib/src/scene_runner/components/pointer_events.rs 0.00% <0.00%> (ø)
...odot-lib/src/scene_runner/components/visibility.rs 0.00% <0.00%> (ø)
...ot-lib/src/scene_runner/components/audio_source.rs 0.00% <0.00%> (ø)
...t-lib/src/scene_runner/components/avatar_attach.rs 0.00% <0.00%> (ø)
...ot-lib/src/scene_runner/components/avatar_shape.rs 0.00% <0.00%> (ø)
...ib/src/scene_runner/components/camera_mode_area.rs 0.00% <0.00%> (ø)
...odot-lib/src/scene_runner/components/text_shape.rs 0.00% <0.00%> (ø)
...t/decentraland-godot-lib/src/scene_runner/scene.rs 21.15% <33.33%> (-0.03%) ⬇️
... and 21 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leanmendoza leanmendoza marked this pull request as ready for review October 26, 2023 18:12
Copy link
Member

@kuruk-mm kuruk-mm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Deleted)

Copy link
Member

@kuruk-mm kuruk-mm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Copy link
Member

@kuruk-mm kuruk-mm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!!

@leanmendoza leanmendoza merged commit ab9ac63 into main Oct 26, 2023
3 checks passed
@leanmendoza leanmendoza deleted the feat/scene-ui branch October 26, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants