Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add gdscript promises to content manager #69

Merged
merged 8 commits into from
Nov 3, 2023

Conversation

kuruk-mm
Copy link
Member

@kuruk-mm kuruk-mm commented Nov 2, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2023

Codecov Report

Attention: 134 lines in your changes are missing coverage. Please review.

Comparison is base (3ef8ce2) 13.26% compared to head (f17773e) 14.77%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   13.26%   14.77%   +1.51%     
==========================================
  Files          91       92       +1     
  Lines       10978    11113     +135     
==========================================
+ Hits         1456     1642     +186     
+ Misses       9522     9471      -51     
Files Coverage Δ
rust/decentraland-godot-lib/src/common/rpc.rs 0.00% <ø> (ø)
...raland-godot-lib/src/scene_runner/scene_manager.rs 5.63% <ø> (+5.30%) ⬆️
...d-godot-lib/src/scene_runner/components/raycast.rs 0.00% <0.00%> (ø)
rust/decentraland-godot-lib/src/comms/profile.rs 26.79% <66.66%> (+26.79%) ⬆️
rust/decentraland-godot-lib/src/comms/livekit.rs 0.00% <0.00%> (ø)
rust/decentraland-godot-lib/src/comms/ws_room.rs 0.00% <0.00%> (ø)
...raland-godot-lib/src/scene_runner/rpc_calls/mod.rs 0.00% <0.00%> (ø)
...dot-lib/src/scene_runner/global_get_node_helper.rs 0.00% <0.00%> (ø)
...aland-godot-lib/src/comms/communication_manager.rs 3.92% <0.00%> (+3.23%) ⬆️
...decentraland-godot-lib/src/avatars/avatar_scene.rs 5.76% <10.00%> (+4.75%) ⬆️
... and 3 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kuruk-mm kuruk-mm changed the title refactor: improve content manager refactor: add gdscript promises to content manager Nov 3, 2023
@kuruk-mm kuruk-mm marked this pull request as ready for review November 3, 2023 01:59
@kuruk-mm kuruk-mm merged commit c628f5a into main Nov 3, 2023
3 checks passed
@kuruk-mm kuruk-mm deleted the feat/improve-content-manager branch November 3, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants