Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement portables experiences #76

Merged
merged 4 commits into from
Nov 8, 2023

Conversation

leanmendoza
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: 335 lines in your changes are missing coverage. Please review.

Comparison is base (d3dba6f) 14.79% compared to head (054fb09) 14.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
- Coverage   14.79%   14.40%   -0.39%     
==========================================
  Files          93       96       +3     
  Lines       11189    11508     +319     
==========================================
+ Hits         1655     1658       +3     
- Misses       9534     9850     +316     
Files Coverage Δ
rust/decentraland-godot-lib/src/dcl/mod.rs 28.57% <ø> (-0.42%) ⬇️
...ntraland-godot-lib/src/godot_classes/dcl_global.rs 74.46% <100.00%> (+0.55%) ⬆️
rust/decentraland-godot-lib/src/common/rpc.rs 0.00% <0.00%> (ø)
rust/decentraland-godot-lib/src/dcl/js/mod.rs 0.00% <0.00%> (ø)
...traland-godot-lib/src/scene_runner/update_scene.rs 0.00% <0.00%> (ø)
...land-godot-lib/src/scene_runner/godot_dcl_scene.rs 33.60% <0.00%> (-0.57%) ⬇️
...raland-godot-lib/src/scene_runner/scene_manager.rs 5.44% <0.00%> (-0.13%) ⬇️
...raland-godot-lib/src/scene_runner/rpc_calls/mod.rs 0.00% <0.00%> (ø)
...-godot-lib/src/scene_runner/rpc_calls/portables.rs 0.00% <0.00%> (ø)
...ust/decentraland-godot-lib/src/dcl/js/portables.rs 0.00% <0.00%> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leanmendoza leanmendoza marked this pull request as ready for review November 7, 2023 23:47
Copy link
Member

@kuruk-mm kuruk-mm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@leanmendoza leanmendoza enabled auto-merge (squash) November 8, 2023 18:34
@leanmendoza leanmendoza merged commit 50002af into main Nov 8, 2023
1 check passed
@leanmendoza leanmendoza deleted the feat/implement-portable-experiences branch November 8, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants