-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: CameraModeArea limits, they only works in the active scene #80
Conversation
feat: new on_active_scene component that emits a signal when the scenes becames active or non-active
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #80 +/- ##
==========================================
+ Coverage 14.55% 14.68% +0.13%
==========================================
Files 96 97 +1
Lines 11542 11573 +31
==========================================
+ Hits 1680 1700 +20
- Misses 9862 9873 +11
☔ View full report in Codecov by Sentry. |
pub struct DclSceneNode { | ||
scene_id: u32, | ||
|
||
is_global: bool, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a property of the scene, not of the entity. Could you move this to the SceneRoot and then go until that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
misunderstood, forget it
pub struct DclSceneNode { | ||
scene_id: u32, | ||
|
||
is_global: bool, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
misunderstood, forget it
feat: new on_active_scene component that emits a signal when the scenes becames active or non-active
Fix #78
How to use it?
OnActiveScene.tscn
to your scene.on_scene_active
to your code.