Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop processing ticks until all gltfs are different of loading state when the scene is loading (tick_number < 3) #82

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

leanmendoza
Copy link
Collaborator

@leanmendoza leanmendoza commented Nov 9, 2023

Follow the specification of delivering the scene loaded after the first tick (after onStart and first onUpdate).

…tate when the scene is loading (tick_number < 3)
@leanmendoza leanmendoza requested a review from kuruk-mm November 9, 2023 18:02
@codecov-commenter
Copy link

Codecov Report

Attention: 105 lines in your changes are missing coverage. Please review.

Comparison is base (80de428) 14.68% compared to head (701b8f6) 14.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
- Coverage   14.68%   14.62%   -0.07%     
==========================================
  Files          97       98       +1     
  Lines       11573    11648      +75     
==========================================
+ Hits         1700     1703       +3     
- Misses       9873     9945      +72     
Files Coverage Δ
...land-godot-lib/src/godot_classes/dcl_scene_node.rs 72.00% <100.00%> (+1.16%) ⬆️
...traland-godot-lib/src/scene_runner/update_scene.rs 0.00% <0.00%> (ø)
...-lib/src/scene_runner/components/gltf_container.rs 0.00% <0.00%> (ø)
...-godot-lib/src/godot_classes/dcl_gltf_container.rs 3.77% <3.77%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leanmendoza leanmendoza merged commit 900bcf1 into main Nov 10, 2023
@leanmendoza leanmendoza deleted the fix/sync-gltf-loading-state-with-tick-number branch November 10, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants