Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add scene coordinator #9

Merged
merged 3 commits into from
Jun 8, 2023
Merged

Conversation

leanmendoza
Copy link
Collaborator

Main goal

Enable change realm (unload and load scenes)

  • Load parcel like genesis-city from pointer
  • Load fixed sceneUrns from the realm

Another fixes

  • Load embed texture from GLTF/GLB
  • Fix reparenting

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 62.93% and project coverage change: +10.77 🎉

Comparison is base (7dc6bac) 26.17% compared to head (8f81679) 36.95%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main       #9       +/-   ##
===========================================
+ Coverage   26.17%   36.95%   +10.77%     
===========================================
  Files          26       31        +5     
  Lines        1952     2752      +800     
===========================================
+ Hits          511     1017      +506     
- Misses       1441     1735      +294     
Impacted Files Coverage Δ
...aland-godot-lib/src/http_request/rust_requester.rs 0.00% <0.00%> (ø)
rust/decentraland-godot-lib/src/lib.rs 33.33% <ø> (-16.67%) ⬇️
...rc/scene_runner/components/transform_and_parent.rs 0.00% <0.00%> (ø)
...land-godot-lib/src/scene_runner/godot_dcl_scene.rs 0.00% <ø> (ø)
...raland-godot-lib/src/scene_runner/scene_manager.rs 0.00% <0.00%> (ø)
...and-godot-lib/src/http_request/request_response.rs 51.16% <51.16%> (ø)
...nd-godot-lib/src/realm/scene_entity_coordinator.rs 62.41% <62.41%> (ø)
rust/decentraland-godot-lib/src/realm/parcel.rs 91.66% <91.66%> (ø)
...aland-godot-lib/src/http_request/http_requester.rs 93.16% <93.16%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@leanmendoza leanmendoza merged commit 4a9c908 into main Jun 8, 2023
@kuruk-mm kuruk-mm deleted the feat/add-realm-scene-coordinator branch October 24, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants