Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avatar modifier area #90

Merged
merged 4 commits into from
Nov 13, 2023
Merged

feat: avatar modifier area #90

merged 4 commits into from
Nov 13, 2023

Conversation

kuruk-mm
Copy link
Member

@kuruk-mm kuruk-mm commented Nov 11, 2023

Fix #74

@kuruk-mm kuruk-mm requested a review from leanmendoza November 11, 2023 21:24
@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2023

Codecov Report

Attention: 91 lines in your changes are missing coverage. Please review.

Comparison is base (5635f9f) 14.62% compared to head (3dc5a7a) 14.52%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   14.62%   14.52%   -0.10%     
==========================================
  Files          98      100       +2     
  Lines       11648    11735      +87     
==========================================
+ Hits         1703     1705       +2     
- Misses       9945    10030      +85     
Files Coverage Δ
...b/src/godot_classes/dcl_avatar_modifier_area_3d.rs 50.00% <50.00%> (ø)
...t/decentraland-godot-lib/src/scene_runner/scene.rs 20.85% <0.00%> (ø)
...traland-godot-lib/src/scene_runner/update_scene.rs 0.00% <0.00%> (ø)
...land-godot-lib/src/scene_runner/godot_dcl_scene.rs 35.29% <0.00%> (+0.86%) ⬆️
...raland-godot-lib/src/scene_runner/scene_manager.rs 5.23% <0.00%> (-0.18%) ⬇️
...rc/scene_runner/components/avatar_modifier_area.rs 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kuruk-mm kuruk-mm requested a review from leanmendoza November 13, 2023 13:57
@kuruk-mm kuruk-mm merged commit 18da188 into main Nov 13, 2023
3 checks passed
@kuruk-mm kuruk-mm deleted the feat/avatar-modifier-area branch November 13, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Video sound only plays in the base parcel (not the entire scene)
3 participants