feat: show new events and fetch correctly #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nachomazzara
requested changes
Nov 7, 2018
scripts/mktcli.js
Outdated
| const blockchainEvents = await BlockchainEvent.findByArgs( | ||
| 'assetId', | ||
| const blockchainEvents = await BlockchainEvent.findByAnyArgs( | ||
| ['assetId', 'landId', '_landId', '_estateId'], |
There was a problem hiding this comment.
Also we have _tokenId for the ERC721 Transfer event
scripts/mktcli.js
Outdated
| @@ -290,7 +304,7 @@ const main = { | |||
| const asset = await getAssetFromCLIArgs(assetId, assetType) | |||
|
|
|||
| const events = await BlockchainEvent.findByAnyArgs( | |||
| ['assetId', '_landId'], | |||
| ['assetId', 'landId', '_landId', '_estateId'], | |||
There was a problem hiding this comment.
Maybe we could add also _tokenId
There was a problem hiding this comment.
Hmm What do you think of using something like:
const argsId = ['assetId', 'landId', '_landId', '_estateId', '_tokenId']
we have the same in two places in the same file
IDK a good name: argsId, wordToMatchId, matchId, argsNames
There was a problem hiding this comment.
Agree with abstracting this!
nicosantangelo
force-pushed
the
feat/add-all-events-to-mkcli
branch
from
4c1b2cc
to
acfcc4d
Compare
|
Updated! let me know what you think of the constant name! (POSSIBLE_ASSET_EVENT_IDS) |
|
|
nachomazzara
approved these changes
Nov 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not trying to be 100% complete with the descriptions