Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: line offset while debugging on vscode/chrome with sourcemaps #211

Merged
merged 2 commits into from
May 15, 2024
Merged

fix: line offset while debugging on vscode/chrome with sourcemaps #211

merged 2 commits into from
May 15, 2024

Conversation

leanmendoza
Copy link
Contributor

@leanmendoza leanmendoza commented May 14, 2024 •
edited
Loading

What?

Make a plain eval to catch the source-maps properly in Preview Mode

@github-actions GitHub Actions
Copy link

Test this pull request

  • The @dcl/scene-runtime package can be tested in scenes by running 
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/scene-runtime/branch/fix/proper-debugging/dcl-scene-runtime-7.0.6-20240514193502.commit-438147c.tgz"

@leanmendoza leanmendoza mentioned this pull request May 14, 2024
Merged
@leanmendoza leanmendoza merged commit adbf9e7 into main May 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gonpombo8 gonpombo8 gonpombo8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leanmendoza @gonpombo8