Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Outdated Twitter Logo to Current Branding #555

Closed
wants to merge 0 commits into from

Conversation

Jagadeeshftw
Copy link
Contributor

@Jagadeeshftw Jagadeeshftw commented Aug 9, 2024

Description

This PR addresses the issue of updating the Twitter icon to the latest version by updating the Twitter SVG icon.

Related Issue

Fixes #554

Changes Made

Verified and updated the Twitter SVG icon in the assets.
Replaced the outdated SVG with the latest version of the Twitter icon.

Screenshots

Dark mode:

image

Light mode:

image

Copy link

vercel bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
decentraland-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 5:19pm

@Jagadeeshftw Jagadeeshftw changed the title Update Outdated Twitter Logo to Current Branding #554 Update Outdated Twitter Logo to Current Branding Aug 9, 2024
@Jagadeeshftw
Copy link
Contributor Author

Jagadeeshftw commented Aug 20, 2024

@LautaroPetaccio Can you please review this?

Copy link
Contributor

@kevinszuchet kevinszuchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thank you for the help @Jagadeeshftw

@kevinszuchet
Copy link
Contributor

Hey @Jagadeeshftw,

I noticed that the first commit is not signed, which is preventing the PR from being available for merge. Could you please sign it? This is a requirement from the base branch. 🙏

Thanks again for your help!

@kevinszuchet
Copy link
Contributor

Maybe this can help https://stackoverflow.com/a/59351278

@Jagadeeshftw
Copy link
Contributor Author

Is it fine now @kevinszuchet ?

@kevinszuchet
Copy link
Contributor

Could you try leaving only the original commit that is now correctly signed?

@Jagadeeshftw
Copy link
Contributor Author

Let me create new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Outdated Twitter Logo to Current Branding
2 participants