Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encodings for elements to be hashed #97

Merged

Conversation

BasileiosKal
Copy link
Contributor

@BasileiosKal BasileiosKal commented Apr 11, 2022

First approach to close issue #96

Encodings suggestion of elements to be hashed (similar to the ones used by U-Prove).

This PR follows option 2 from the above issue, i.e., the encoding of elements to be hashed is described in a separate section and used implicitly throughout the document. See PR #95 for more context.

I also suggest that scalars, non-negative integers, and generic octet strings must always be prepended with their length while it is only recommended for EC points.

@BasileiosKal BasileiosKal mentioned this pull request Apr 11, 2022
draft-bbs-signatures.md Outdated Show resolved Hide resolved
draft-bbs-signatures.md Outdated Show resolved Hide resolved
draft-bbs-signatures.md Outdated Show resolved Hide resolved
draft-bbs-signatures.md Outdated Show resolved Hide resolved
draft-bbs-signatures.md Outdated Show resolved Hide resolved
@BasileiosKal
Copy link
Contributor Author

Updates proposed by @mikelodder7 and @andrewwhitehead during the WG call of 18/ 4/2022:

  1. Lengths are extended to 8 bytes (for non-DST’s octet strings). Non-negative integers are also updated to be represented with 8 bytes, to be consistent with the representation of the lengths of octet strings (which are also non-negative integers).
  2. The second paragraph is updated to make use of I2OSP (instead of zero-extensions).
  3. The example is updated accordingly.

Copy link
Contributor

@mikelodder7 mikelodder7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

draft-bbs-signatures.md Outdated Show resolved Hide resolved
Co-authored-by: Tobias Looker <tplooker@gmail.com>
@tplooker
Copy link
Member

Multiple reviews and now approvals, open 10 days, discussed on latest WG call, merging

@tplooker tplooker merged commit d9b3a35 into decentralized-identity:main Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants