Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating uint8arrays package to lts stable #312

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updating uint8arrays package to lts stable #312

wants to merge 1 commit into from

Conversation

mzkrasner
Copy link

@mzkrasner mzkrasner commented May 30, 2024 •
edited
Loading

Current outdated uint8arrays package versions are conflicting with modern bundlers as we're seeing in certain integrated environments (such as Next.js v14+).

This PR updates uint8arrays to latest stable (v5)

  • Tests continue to pass
  • Builds successfully

@ukstv
Copy link
Contributor

ukstv commented May 30, 2024

@mirceanis Could you please have a look at the PR? It updates uint8arrays to the latest stable v5.

@mzkrasner mzkrasner mentioned this pull request May 30, 2024
Closed
@stale Stale
Copy link

stale bot commented Aug 11, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 11, 2024
@mirceanis
Copy link
Member

Hey folks,
We had the version of uint8arrays fixed to 3.1.1 as that was the last version publishing a CommonJS compatible package. Later pure-ESM releases cause issues in commonJS environments.
Even though I would prefer to move to ESM I'm not sure how to reconcile these 2 scenarios.

@ukstv
Copy link
Contributor

ukstv commented Aug 20, 2024

There is a way: move to pure ESM. Nodejs handles ESM pretty well these days, as well as the bundlers.

@stale stale bot closed this Sep 7, 2024
@mirceanis mirceanis added pinned a known issue or feature that should not be closed by bots and removed stale labels Sep 8, 2024
@mirceanis mirceanis reopened this Sep 8, 2024
mirceanis added a commit that referenced this pull request Jan 16, 2025
@mirceanis
fix(deps): update dependencies
a79dc9d 
closes #312

BREAKING CHANGE: this updates multiformats and uint8arrays dependencies to versions that only publish ESM variants
@mirceanis mirceanis mentioned this pull request Jan 16, 2025
Merged
mirceanis added a commit that referenced this pull request Jan 16, 2025
@mirceanis
fix(deps): update dependencies (#320)
69b2a0d 
closes #312

BREAKING CHANGE: this updates multiformats and uint8arrays dependencies to versions that only publish ESM variants
uport-automation-bot pushed a commit that referenced this pull request Jan 16, 2025
@semantic-release-bot
chore(release): 9.0.0-alpha.1 [skip ci]
d6e3f75 
# [9.0.0-alpha.1](8.0.6...9.0.0-alpha.1) (2025-01-16)

### Bug Fixes

* **deps:** update dependencies ([#320](#320)) ([69b2a0d](69b2a0d)), closes [#312](#312)

### BREAKING CHANGES

* **deps:** this updates multiformats and uint8arrays dependencies to versions that only publish ESM variants
@uport-automation-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 9.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pinned a known issue or feature that should not be closed by bots released on @alpha
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mzkrasner @ukstv @mirceanis @uport-automation-bot