-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for didResolutionMetadata and didDocumentMetadata #79
Comments
Yes, thank you for flagging this! |
I'm planning to do that yes! :) |
To reduce complexity, ensure spec compliance and code readability, I will likely make this a breaking change without backwards compatibility. This means that all method specific resolvers would need to be changed in order to support the new version. |
A breaking change is unfortunate, but if it is indeed necessary it should not be a show-stopper. Do you have an example of the change required? |
# [3.0.0](2.2.0...3.0.0) (2021-03-02) ### Features * update resolve method signature to match did core spec ([#82](#82)) ([313e685](313e685)), closes [#79](#79) ### BREAKING CHANGES * the `Resolver` and `DIDResolver` data types have been upgraded. To use a legacy resolver that simply returns a `DIDDocument`, please register it under the `options.legacyResolvers` constructor param
🎉 This issue has been resolved in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
According to did-core a resolver function should have the following abstract form:
Currently the function signature for this library looks like this:
We should introduce a breaking change that adds support for returning didResolutionMetadata and didDocumentMetadata.
It should be possible to implement this in a way in which all resolvers won't break with the new version of this package, but won't provide additional metadata until they implement the new interface.
The new function signature would look something like this:
The text was updated successfully, but these errors were encountered: