Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#207 - Simplified docker-compose and added support for testnet #278

Merged
merged 6 commits into from
Sep 16, 2022

Conversation

thehenrytsai
Copy link
Collaborator

  1. added testnet docker support
  2. simplified docker-compose files, so now it is a one-command deployment
  3. introduced the usage of ION docker images

Looking for people who are willing to test the new docker instructions before this is merged.

@thehenrytsai thehenrytsai added help wanted Extra attention is needed good first issue Good for newcomers improvement Improvement to an existing feature that does not require a fork labels Jun 24, 2022
@thehenrytsai thehenrytsai changed the title [WIP] Simplified docker-compose and added support for testnet [WIP] #207 - Simplified docker-compose and added support for testnet Jun 24, 2022
@monakaJP
Copy link

Hi, I tried this following readme.md. But readme.md's docker-compose version is old. I think it shold be changed "sudo curl -L https://github.com/docker/compose/releases/download/v2.6.0/docker-compose-`uname -s-uname -m` -o /usr/local/bin/docker-compose"

@thehenrytsai
Copy link
Collaborator Author

@monakaJP, thank you for trying out the README.md, I have updated the curl command based on your feedback. Were you able to progress further and run an ION node successfully?

@monakaJP
Copy link

monakaJP commented Jul 7, 2022

@thehenrytsai Hi. it was succeeded on Ubuntu 20.04. DID can now be resolved. If anything, a docker image for linux would be nice. I made it on dockerhub https://hub.docker.com/r/monakajp/ion/tags.

@thehenrytsai
Copy link
Collaborator Author

a docker image for linux would be nice.

Hi @monakaJP, thanks for the fast response, I am not clear what you mean by a Linux docker image? The ION docker-image is already based off Linux (alpine), but I guess that’s not what you mean?

@monakaJP
Copy link

monakaJP commented Jul 7, 2022

@thehenrytsai I'm sorry for I didn't explain. Maybe it is cpu architecture problem. I failed to build it on x86_64 environment. So I build new image and used it. I thick we should add another architecture or edit how to build image.

@thehenrytsai
Copy link
Collaborator Author

@monakaJP, ah! This is my bad, I forgot that I am developing on a Macbook with M1 chip, as a result it built the ION image in arm64 architecture. Let me look into fixing this!

@thehenrytsai
Copy link
Collaborator Author

@monakaJP, I have updated the docker README and pushed a multi-platform ION image!

@thehenrytsai thehenrytsai changed the title [WIP] #207 - Simplified docker-compose and added support for testnet #207 - Simplified docker-compose and added support for testnet Jul 13, 2022
@monakaJP
Copy link

@thehenrytsai Great. Thank you for upgrade!

@thehenrytsai
Copy link
Collaborator Author

With today's commit, I think the PR is ready for final review and merge, will let this hang for a couple more days for more comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed improvement Improvement to an existing feature that does not require a fork
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants