-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#207 - Simplified docker-compose and added support for testnet #278
Conversation
Hi, I tried this following readme.md. But readme.md's docker-compose version is old. I think it shold be changed "sudo curl -L https://github.com/docker/compose/releases/download/v2.6.0/docker-compose-`uname -s |
@monakaJP, thank you for trying out the |
@thehenrytsai Hi. it was succeeded on Ubuntu 20.04. DID can now be resolved. If anything, a docker image for linux would be nice. I made it on dockerhub https://hub.docker.com/r/monakajp/ion/tags. |
Hi @monakaJP, thanks for the fast response, I am not clear what you mean by a Linux docker image? The ION docker-image is already based off Linux (alpine), but I guess that’s not what you mean? |
@thehenrytsai I'm sorry for I didn't explain. Maybe it is cpu architecture problem. I failed to build it on x86_64 environment. So I build new image and used it. I thick we should add another architecture or edit how to build image. |
@monakaJP, ah! This is my bad, I forgot that I am developing on a Macbook with M1 chip, as a result it built the ION image in arm64 architecture. Let me look into fixing this! |
@monakaJP, I have updated the docker README and pushed a multi-platform ION image! |
@thehenrytsai Great. Thank you for upgrade! |
With today's commit, I think the PR is ready for final review and merge, will let this hang for a couple more days for more comments. |
testnet
docker supportLooking for people who are willing to test the new docker instructions before this is merged.