Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Veramo LD suites can only signal support for a single type of Verification Method #1329

Closed
mirceanis opened this issue Jan 26, 2024 · 0 comments · Fixed by #1331
Closed

Veramo LD suites can only signal support for a single type of Verification Method #1329

mirceanis opened this issue Jan 26, 2024 · 0 comments · Fixed by #1331
Assignees
Labels
bug Something isn't working

Comments

@mirceanis
Copy link
Member

Bug severity
4

Describe the bug

Some suites would work with multiple verification method types.
Examples:

  • EcdsaSecp256k1RecoverySignature2020 should be verifiable using EcdsaSecp256k1VerificationKey2019 as well as EcdsaSecp256k1RecoveryMethod2020 since the Secp256k1 public key can also be expressed as the recovery method (blockchainAccountId).
  • Ed25519Signature2020 should be verifiable with Ed25519VerificationKey2020 as well as Ed25519VerificationKey2018 since the raw public key material is essentially the same.
  • Almost all signature suites should at least attempt to verify against JsonWebKey2020 or Multikey verification methods as long as the public key types match the signature algorithms.

Additional context

// FIXME: some suites would work for multiple key types, but this only returns a single value per suite.

Versions (please complete the following information):

  • Veramo: <=5.x
@mirceanis mirceanis added the bug Something isn't working label Jan 26, 2024
@mirceanis mirceanis self-assigned this Jan 26, 2024
mirceanis added a commit that referenced this issue Jan 26, 2024
The `VeramoLdSignature.getSupportedVerificationType()` can now return `string[]` as well as `string`

fixes #1329
mirceanis added a commit that referenced this issue Jan 26, 2024
…ods (#1331)

The `VeramoLdSignature.getSupportedVerificationType()` can now return `string[]` as well as `string`

fixes #1329
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant