Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): correctly extract publicKeyHex from [Ed/X]25519 2020 keys #1076

Merged
merged 3 commits into from
Nov 28, 2022

Conversation

nickreynolds
Copy link
Contributor

What issue is this PR fixing

closes #1067

What is being changed

Add support for 2020 key types in extractPublicKeyHex util function

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran yarn, yarn build, yarn test, yarn test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.
  • I did not add automated tests because _________, and I am aware that a PR without tests will likely get rejected.

@codecov
Copy link

codecov bot commented Nov 27, 2022

Codecov Report

Merging #1076 (ec58360) into next (125bf42) will decrease coverage by 0.22%.
The diff coverage is 78.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1076      +/-   ##
==========================================
- Coverage   80.25%   80.02%   -0.23%     
==========================================
  Files         118      127       +9     
  Lines        4056     4606     +550     
  Branches      875      999     +124     
==========================================
+ Hits         3255     3686     +431     
- Misses        798      920     +122     
+ Partials        3        0       -3     

Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@mirceanis mirceanis merged commit c73002c into next Nov 28, 2022
@mirceanis mirceanis deleted the nickreynolds/2020-keys branch November 28, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to pack encrypted didcomm message for certain 25519 keys
2 participants