-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(utils): convert JWK with curv Ed25519
to X25519
#1078
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1078 +/- ##
==========================================
- Coverage 80.25% 80.01% -0.24%
==========================================
Files 118 127 +9
Lines 4056 4608 +552
Branches 875 1000 +125
==========================================
+ Hits 3255 3687 +432
- Misses 798 921 +123
+ Partials 3 0 -3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
Do you plan to fill the todo
test cases as well?
I would like to add tests for all the |
No, we don't. Private key data has to be converted to hex. We should be able to do the conversion with existing utils/deps: |
In our SSI Wallet we have code that actually has support to covert DID jwk and thus JWKs to hex. We intent to bring that to Veramo, but maybe you can already use it The last 3 methods are basically delegating to Veramo and then have specific support for JWKs |
Btw we also have a did jwk provider and resolver https://github.com/Sphereon-Opensource/ssi-sdk/tree/develop/packages/jwk-did-provider |
The |
What is being changed
allow
JsonWebKeys
withcrv = Ed25519
to be converted tocrv = X25519
Quality
Check all that apply:
yarn
,yarn build
,yarn test
,yarn test:browser
locally.