-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(did-provider-pkh): refactor and simplify did:pkh plugin #1113
Conversation
- use of namespace parameter - allow passing privateKey to import key directly on identifier creation
Codecov ReportBase: 85.13% // Head: 84.97% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## next #1113 +/- ##
==========================================
- Coverage 85.13% 84.97% -0.16%
==========================================
Files 140 140
Lines 14024 14050 +26
Branches 1422 1428 +6
==========================================
Hits 11939 11939
- Misses 2085 2111 +26
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing this.
Since this is meant to clean up some code, I also made some notes that should make this align better with the patterns we use in other parts of the codebase.
It's mostly about error messages and debug output. Please take a look.
Co-authored-by: Mircea Nistor <mirceanis@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates.
I suggested some more tiny fixes.
What issue is this PR fixing
There's no issue being fixed, just small improvements on did-provider-pkh plugin:
What is being changed
Only changing did-provider-pkh plugin.
Quality
Check all that apply:
pnpm i
,pnpm build
,pnpm test
,pnpm test:browser
locally.