refactor(cli): use individual Command
instances instead of global program
#1130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue is this PR fixing
This PR refactors the way commander.js is used in the CLI package.
Instead of a global
program
command being mutated by different imports, each subcommand is created as an independent instance of aCommand
object.The main purpose is to simplify testing, however due to incompatibilities between jest/ESM/chalk/typeorm the tests can't actually be performed using the same testing harness.
A custom jest config would be needed that must only be used on the CLI tests. When enabling the workaround in jestjs/jest#12270 (comment) any tests using typeorm in any way will fail.
This means we'd also need to only use JSON storage or memory storage configs in these CLI tests.
This PR also exports some of the methods used to configure the CLI through yaml.
Quality
Check all that apply:
pnpm i
,pnpm build
,pnpm test
,pnpm test:browser
locally.