Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: using IPFS CID instead of hex blake2 hashes #1239

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Conversation

simonas-notcat
Copy link
Contributor

What issue is this PR fixing

This PR is changing hashing algorithm from blake2 to the one that is being used by IPFS

What is being changed

@veramo/utils computeEntryHash now uses another hash algorithm. It is mainly used for computing a unique hash for VerifiableCredentials when storing them in the DB

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.
  • I did not add automated tests because _________, and I am aware that a PR without tests will likely get rejected.

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (fcd2699) 84.92% compared to head (42c255c) 84.93%.
Report is 2 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1239   +/-   ##
=======================================
  Coverage   84.92%   84.93%           
=======================================
  Files         167      167           
  Lines       18120    18132   +12     
  Branches     2036     2036           
=======================================
+ Hits        15388    15400   +12     
  Misses       2732     2732           
Files Changed Coverage Δ
packages/utils/src/credential-utils.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nickreynolds nickreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine to me, but @mirceanis should definitely review since it brings in some new dependencies

Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, we'll merge this as a breaking change.

@mirceanis mirceanis merged commit acc47e6 into next Sep 21, 2023
@mirceanis mirceanis deleted the feat/blake2b-to-ipld branch September 21, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants