fix(data-store-json): order credentials with weird issuanceDate #1273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is being changed
Some credentials from the wild are missing an
issuanceDate
, or have the date in a non-parseable format.This fix defaults their date to unixtime(0) when compared to other credentials for database sorting.
Quality
Check all that apply:
pnpm i
,pnpm build
,pnpm test
,pnpm test:browser
locally.data-store-json
plugin accepts undefinedissuanceDate
.Details
I added #1274 to demonstrate how a test for this might look like, but it would introduce a breaking change (if people use their own migrations)