Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): move file to utils package #1298

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

cre8
Copy link
Contributor

@cre8 cre8 commented Dec 8, 2023

Signed-off-by: Mirko Mollik mirko.mollik@fit.fraunhofer.de

What is being changed

I moved the jwk util class to the util package based on a discussion with @mirceanis on discord.

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.
  • I did not add automated tests because I only moved existing files, and I am aware that a PR without tests will likely get rejected.

Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (462735d) 85.89% compared to head (c18cd1f) 85.45%.

Files Patch % Lines
packages/did-provider-jwk/src/jwk-did-provider.ts 53.84% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1298      +/-   ##
==========================================
- Coverage   85.89%   85.45%   -0.45%     
==========================================
  Files         170      170              
  Lines       18939    18926      -13     
  Branches     2137     2112      -25     
==========================================
- Hits        16268    16173      -95     
- Misses       2671     2753      +82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for pushing this!

@mirceanis mirceanis merged commit fc94764 into decentralized-identity:next Dec 8, 2023
9 checks passed
@cre8 cre8 deleted the feat/jwk-did-utils branch December 8, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants