Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data-store-orm): remove double entries #1299

Merged
merged 3 commits into from
Dec 8, 2023

Conversation

cre8
Copy link
Contributor

@cre8 cre8 commented Dec 8, 2023

Signed-off-by: Mirko Mollik mirko.mollik@fit.fraunhofer.de

What issue is this PR fixing

fixes #1285

What is being changed

It will reduce the credentials in case there were multiuple claims pointing to the claim credential

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.
  • I did not add automated tests because there was no existing test for this function and I am aware that a PR without tests will likely get rejected.

Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like there is a test that was validating the old buggy behavior:

expect(credentials.length).toBe(3)

It should expect the result length to be 1 instead of 3

The same test exists in the data-store-json package and it is correctly expecting 1 there. It's a good thing you caught this bug :)

cre8 added 2 commits December 8, 2023 12:59
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (462735d) 85.89% compared to head (c626cab) 85.46%.
Report is 2 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1299      +/-   ##
==========================================
- Coverage   85.89%   85.46%   -0.44%     
==========================================
  Files         170      170              
  Lines       18939    18939              
  Branches     2137     2115      -22     
==========================================
- Hits        16268    16186      -82     
- Misses       2671     2753      +82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cre8
Copy link
Contributor Author

cre8 commented Dec 8, 2023

@mirceanis didn't find a way to run the test locally just for one package. Fixed it and it passed in the ci

Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mirceanis mirceanis merged commit 5aa97a2 into decentralized-identity:next Dec 8, 2023
9 checks passed
@cre8 cre8 deleted the fix/issue-1285 branch December 8, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remote agents returns VCs three times
3 participants