-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(data-store-orm): remove double entries #1299
Conversation
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like there is a test that was validating the old buggy behavior:
expect(credentials.length).toBe(3) |
It should expect the result length to be 1 instead of 3
The same test exists in the data-store-json package and it is correctly expecting 1 there. It's a good thing you caught this bug :)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #1299 +/- ##
==========================================
- Coverage 85.89% 85.46% -0.44%
==========================================
Files 170 170
Lines 18939 18939
Branches 2137 2115 -22
==========================================
- Hits 16268 16186 -82
- Misses 2671 2753 +82 ☔ View full report in Codecov by Sentry. |
@mirceanis didn't find a way to run the test locally just for one package. Fixed it and it passed in the ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Signed-off-by: Mirko Mollik mirko.mollik@fit.fraunhofer.de
What issue is this PR fixing
fixes #1285
What is being changed
It will reduce the credentials in case there were multiuple claims pointing to the claim credential
Quality
Check all that apply:
pnpm i
,pnpm build
,pnpm test
,pnpm test:browser
locally.