Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposal] make path output from generate schema dynamic #1318

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

cre8
Copy link
Contributor

@cre8 cre8 commented Jan 19, 2024

What issue is this PR fixing

Example:
fixes #1317

What is being changed

Adding a new parameter to the cli so the path and file of the plugin.schema.json.

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.
  • I did not add automated tests because _________, and I am aware that a PR without tests will likely get rejected.

Fixes decentralized-identity#1317

Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c050588) 85.47% compared to head (aad9354) 85.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1318   +/-   ##
=======================================
  Coverage   85.47%   85.47%           
=======================================
  Files         170      170           
  Lines       18952    18952           
  Branches     2116     2116           
=======================================
  Hits        16199    16199           
  Misses       2753     2753           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mirceanis mirceanis changed the base branch from next to main January 19, 2024 14:44
@mirceanis mirceanis changed the base branch from main to next January 19, 2024 14:44
Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@mirceanis mirceanis merged commit ade95c7 into decentralized-identity:next Jan 19, 2024
9 checks passed
mirceanis added a commit that referenced this pull request Jan 25, 2024
…d export the schemas from each package

relates to #1318 / #1317
mirceanis added a commit that referenced this pull request Jan 25, 2024
* remove references to the JSON build output for plugin schemas
* export the schemas from each package

relates to #1318 / #1317 / #1315
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] make path output from generate schema dynamic
3 participants