Automate GH Release Publication #256
Conversation
leordev
requested review from
amika-sq,
mistermoe,
nitro-neal,
tomdaffurn,
phoebe-lew,
diehuxx,
kirahsapong,
jiyoonie9 and
frankhinek
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #256 +/- ##
=======================================
Coverage 75.78% 75.78%
=======================================
Files 43 43
Lines 1900 1900
Branches 342 342
=======================================
Hits 1440 1440
Misses 313 313
Partials 147 147
|
leordev
force-pushed
the
leordev/autoreleases
branch
from
c1eb088 to
b41f551
Compare
|
Can I have your eyes on the new release instructions that I added, please? @KendallWeihe @jiyoontbd @ALRubinger |
|
|
||
| 3. Run workflow! | ||
|
|
||
| **DON'T FORGET THE `-SNAPSHOT` SUFFIX**, otherwise it will generate publish a new official release to maven registry. |
There was a problem hiding this comment.
Hmmm I wonder if maybe we should implement something to prevent accidents here. Like, maybe we have a dedicated workflow for pre-release, even though everything would be the same as a production release, at least the developer would be more intentional from the page load? Idk I still don't love that idea... what could we do? 🤔
There was a problem hiding this comment.
Maybe somehow SNAPSHOT would be the default and it would require developer intervention to override it?
There was a problem hiding this comment.
@KendallWeihe - This is a great point; @leordev @finn-tbd and I are going to handle this as part of #217 . There will then be 2 workflows: one for SNAPSHOTs and one for releases. Each workflow will perform precondition checks on the user input for version to make sure the -SNAPSHOT suffix is either present or not depending upon the workflow.
Similar to TBD54566975/tbdex-kt#188