Fix for saving an Election that wasn't blocked #10903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecslupu
added
type: fix
alecslupu
approved these changes
Jul 13, 2023
This was referenced Jul 14, 2023
entantoencuanto
added a commit
that referenced
this pull request
Jul 19, 2023
…ure/redesign-staging * feature/redesign-participatory-process-steps: Hide active step item from dropdown metadata if there are no steps present Remove participatory process steps index path, controller and views Adapt participatory process steps specs to redesign using steps modal Change paths in participatory processes events to not use steps index path Change path in process dropdown metadata for steps to call index with steps modal open Extract to process step modal to a cell with an option to display open allow passing options to Dialogs via data-attributes Typo fix guide_example_apps.adoc (#11202) Fix open-ended dependency on doorkeeper (#11197) Fix for saving an Election that wasn't blocked (#10903) CSV & JSON export function fix (#11145) Fix dependencies between modules with i18n strings (#11156) Add Events support for Command (#11064) Load the editor JS only when needed with redesign (#11177) Bump rails from 6.1.7.3 to 6.1.7.4 (#11172) Fix the unused keyword arguments for the budgets workflows (#11174)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
While working in
decidim-elections, I noticed that if you have an Election with an `start_date in the past (ie an ongoing Election that wasn't sent to the Bulletin Board), the application doesn't allow you to make some changes in it (like creating/deleting/updating Questions and Answers).This doesn't make sense, as it shouldn't allow admins to make changes only once the Election was sent to the Bulletin Board, as making changes once the Election was sent could generate synchronization issues (like adding a question after it was sent). For signaling this we don't use the
start_dateattribute, but theblocked_atattribute, accessible through theelection#blocked?method.This PR fixes that.
Testing
(Before the patch)
start_dateof an Election to some time in the past (like 1 week ago)(After the patch)
start_dateof an Election to some time in the past (like 1 week ago)