Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with get_instance_id_info option params #98

Merged
merged 3 commits into from
Feb 21, 2022

Conversation

jsparling
Copy link
Contributor

Issue:

  • The FCM API allows for a detail=true parameter. This will retrieve topic subscription information.
  • The existing get_instance_id_info method takes an options parameter, but is not being properly passed to the Faraday connection.
    • what is sent: https://iid.googleapis.com/iid/info/42?query[details]=true
    • what is expected: https://iid.googleapis.com/iid/info/42?details=true

Change:

  • Update get_instance_id_info method to not wrap the options with in a hash with query

@@ -499,6 +499,40 @@
# TODO
end

describe 'getting instance info' do
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/BlockLength: Block has too many lines. [27/25]

@sabman sabman merged commit 1fbdbfe into decision-labs:master Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants