Update terminal-notifier to 2.0.0 #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for doing this...I've never had anyone update the binary for this repo so I need to check a few things before I merge. I'll keep you posted. |
gabzim
reviewed
May 16, 2019
| <key>NSHumanReadableCopyright</key> | ||
| <string>Copyright © 2012 Eloy Durán. All rights reserved.</string> | ||
| <string>Copyright © 2012-2017 Eloy Durán, Julien Blanchard. All rights reserved.</string> |
There was a problem hiding this comment.
isn't it a little much to add yourself to the authors based on this pr?
There was a problem hiding this comment.
I was looking at this PR, this the updated plist from terminal-notifier.
https://github.com/julienXX/terminal-notifier/blob/3ba9ce569e234062d09c8fd01c4be11e56a9fd1b/Terminal%20Notifier/Terminal%20Notifier-Info.plist#L30
The extra author is a contributor to terminal notifier, not the author of the PR :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under the new OS X system, it seems that the old version of the terminal-notifier does not support the
Linkfield. I have seen other people feedback similar questions. #13I updated the terminal-notifier in the code to their latest version 2.0.0. The binary file use zip and gz compressed. The local test is ok.