Fixed golangci-lint errors

Signed-off-by: vadimartynov <vadim.martynov@flant.com>

modules/150-user-authn/template_tests/kubeconfig_generator_config_test.go

@@ -210,7 +210,7 @@ Multiline
 					Expect(cl.Get("client_secret").String()).To(Equal(dexClientAppSecret))
 					Expect(cl.Get("issuer").String()).To(Equal("https://dex.example.com/"))
 					Expect(cl.Get("k8s_master_uri").String()).To(Equal(a.masterURI))
-					Expect(cl.Get("name").String()).To(Equal(fmt.Sprintf("%s", a.id)))
+					Expect(cl.Get("name").String()).To(Equal(a.id))
 					Expect(cl.Get("redirect_uri").String()).To(Equal(fmt.Sprintf("https://kubeconfig.example.com/callback/%v", i)))
 					Expect(cl.Get("short_description").String()).To(Equal(a.desc))
 					Expect(cl.Get("scopes.0").String()).To(Equal("audience:server:client_id:kubernetes"))

modules/500-upmeter/hooks/smokemini/internal/scheduler/deleter.go

@@ -76,7 +76,7 @@ type loggingDeleter struct {
 
 func (d *loggingDeleter) Delete(name string) {
 	d.delegate.Delete(name)
-	d.logger.Warnf(d.message(name))
+	d.logger.Warn(d.message(name))
 }
 
 // objDeleter is the generic implementation of a Deleter interface

testing/matrix/linter/rules/modules/images.go

@@ -227,6 +227,7 @@ func lintOneDockerfileOrWerfYAML(name, filePath, imagesPath string) errors.LintR
 							"MODULE001",
 							fmt.Sprintf("module = %s, image = %s", name, relativeFilePath),
 							fromTrimmed,
+							"%s",
 							message,
 						)
 					}
@@ -253,6 +254,7 @@ func lintOneDockerfileOrWerfYAML(name, filePath, imagesPath string) errors.LintR
 				"MODULE001",
 				fmt.Sprintf("module = %s, image = %s", name, relativeFilePath),
 				fromInstruction,
+				"%s",
 				message,
 			)
 		}

testing/matrix/linter/rules/modules/monitoring.go

@@ -36,6 +36,7 @@ func dirExists(moduleName, modulePath string, path ...string) (bool, errors.Lint
 			"MODULE060",
 			moduleLabel(moduleName),
 			path,
+			"%s",
 			err.Error(),
 		)
 	}
@@ -86,6 +87,7 @@ func monitoringModuleRule(moduleName, modulePath, moduleNamespace string) errors
 			"MODULE060",
 			moduleLabel(moduleName),
 			searchingFilePath,
+			"%s",
 			err.Error(),
 		)
 	}

testing/matrix/linter/rules/modules/oss.go

@@ -39,6 +39,7 @@ func ossModuleRule(name, moduleRoot string) linterrors.LintRuleErrorsList {
 				"MODULE001",
 				moduleLabel(name),
 				nil,
+				"%s",
 				ossFileErrorMessage(err),
 			)
 

testing/matrix/linter/rules/modules/testgo.go

@@ -91,6 +91,7 @@ func commonTestGoForHooks(name, path string) errors.LintRuleError {
 			"MODULE001",
 			moduleLabel(name),
 			nil,
+			"%s",
 			errstr,
 		)
 	}

testing/matrix/linter/rules/rules.go

@@ -509,7 +509,8 @@ func objectSecurityContext(object storage.StoreObject) errors.LintRuleError {
 			"MANIFEST003",
 			object.Identity(),
 			nil,
-			fmt.Sprintf("GetPodSecurityContext failed: %v", err),
+			"GetPodSecurityContext failed: %v",
+			err,
 		)
 	}
 
@@ -651,7 +652,8 @@ func objectHostNetworkPorts(object storage.StoreObject) errors.LintRuleError {
 			"MANIFEST003",
 			object.Identity(),
 			nil,
-			fmt.Sprintf("IsHostNetwork failed: %v", err),
+			"IsHostNetwork failed: %v",
+			err,
 		)
 	}
 
@@ -661,7 +663,8 @@ func objectHostNetworkPorts(object storage.StoreObject) errors.LintRuleError {
 			"MANIFEST003",
 			object.Identity(),
 			nil,
-			fmt.Sprintf("GetContainers failed: %v", err),
+			"GetContainers failed: %v",
+			err,
 		)
 	}
 	initContainers, err := object.GetInitContainers()
@@ -670,7 +673,8 @@ func objectHostNetworkPorts(object storage.StoreObject) errors.LintRuleError {
 			"MANIFEST003",
 			object.Identity(),
 			nil,
-			fmt.Sprintf("GetInitContainers failed: %v", err),
+			"GetInitContainers failed: %v",
+			err,
 		)
 	}
 	containers = append(containers, initContainers...)