refactor(kube-api-rewriter): renaming before refactoring rewrites #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: No significant changes in rewriters are made, except simple refactoring in some places: - Extract RewriteRoleRule for common code in validating, mutating, clusterrole and role. - Support @root path for all transformers. Main changes: - Move traversing methods to transform package. - Move rules related code to rules package. - Make rewriters one resource rewriters - Move ResourceOrList calls out of rewriters to rule_rewriter.go - Fix: enable rewrite for ServiceMonitorList. Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
universal-itengineer
force-pushed
the
main
branch
from
d444891
to
6e0c7e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NOTE: No significant changes in rewriters are made, except simple refactoring in some places:
@Rootpath for all transformers.Main changes:
Why do we need it, and what problem does it solve?
It is the first step in rewriters code optimization. Open a separate PR to reduce renaming noise in the next PRs.
What is the expected result?
Everything works as before, even bugs.
Checklist