Skip to content

Conversation

@fl64
Copy link
Member

@fl64 fl64 commented Oct 13, 2025

Description

update due v1.2.0

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: module
type: chore
summary: update due v1.2.0
impact_level: low

@fl64 fl64 self-assigned this Oct 13, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 13, 2025

Reviewer's Guide

Introduces warning alerts clarifying project-level resource scope and refines disk and live migration guidance in the user guide for version 1.2.0.

Flow diagram for VM image resource selection and scope

flowchart TD
    A["User wants to use VM image"] --> B["Choose resource type"]
    B --> C["VirtualImage (project/namespace scope)"]
    B --> D["ClusterVirtualImage (cluster-wide scope)"]
    C --> E["Image available only in project/namespace"]
    D --> F["Image available cluster-wide"]
Loading

File-Level Changes

Change Details Files
Clarify VirtualImage resource scope with warning alerts
  • Added warning block explaining VirtualImage is project-scoped
  • Referenced ClusterVirtualImage for cluster-level image usage
docs/USER_GUIDE.ru.md
docs/USER_GUIDE.md
Refine disk section wording and formatting
  • Reworded disk purpose and storage type descriptions
  • Standardized terminology for VolumeBindingMode and AccessMode
docs/USER_GUIDE.ru.md
Add live migration prerequisites and policy guidance
  • Inserted warning about disk availability on target nodes for live migration
  • Noted need for liveMigrationPolicy configuration in VM spec
docs/USER_GUIDE.ru.md
docs/USER_GUIDE.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@Isteb4k Isteb4k added this to the v1.1.1 milestone Oct 14, 2025
@nevermarine nevermarine modified the milestones: v1.1.1, v1.2.0 Oct 16, 2025
@fl64 fl64 force-pushed the docs/module/update-due-v1.2.0 branch 4 times, most recently from 158d428 to efda6e2 Compare October 28, 2025 06:08
@fl64 fl64 force-pushed the docs/module/update-due-v1.2.0 branch from b41e58e to a029c9d Compare October 30, 2025 06:06
@neermilov
Copy link
Member

Maybe it would be helpful to add a note to documentation that in order to use the d8 data export download feature, you'll need to enable the "storage-volume-data-manager" module due to an error:

Error: DataExporter create error: no matches for kind 'DataExport' in version 'storage.deckhouse.io/v1alpha1'

@fl64 fl64 force-pushed the docs/module/update-due-v1.2.0 branch 3 times, most recently from c0fe9ec to bd559d3 Compare November 24, 2025 12:48
fl64 and others added 12 commits November 24, 2025 18:18
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
Signed-off-by: Dmitry Prytkov <dmitry.prytkov@flant.com>
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
…onal network interfaces

Signed-off-by: Dmitry Prytkov <dmitry.prytkov@flant.com>
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
fl64 and others added 12 commits November 24, 2025 18:44
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
Signed-off-by: Vladislav Panfilov <vladislav.panfilov@flant.com>
Signed-off-by: Vladislav Panfilov <vladislav.panfilov@flant.com>
prismagod
prismagod previously approved these changes Nov 25, 2025
* docs(dvcr): add section about dvcr garbage collection


---------

Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
Signed-off-by: Vladislav Panfilov <97229646+prismagod@users.noreply.github.com>
Co-authored-by: Vladislav Panfilov <97229646+prismagod@users.noreply.github.com>
Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
Signed-off-by: Vladislav Panfilov <vladislav.panfilov@flant.com>
@Isteb4k Isteb4k modified the milestones: v1.2.0, v1.3.0 Nov 26, 2025
@Isteb4k Isteb4k merged commit 1f4ae4e into main Nov 27, 2025
29 of 32 checks passed
@Isteb4k Isteb4k deleted the docs/module/update-due-v1.2.0 branch November 27, 2025 10:20
Isteb4k pushed a commit that referenced this pull request Nov 27, 2025
Update due v1.2.0

---------

Signed-off-by: Pavel Tishkov <pavel.tishkov@flant.com>
Signed-off-by: Dmitry Prytkov <dmitry.prytkov@flant.com>
Signed-off-by: Vladislav Panfilov <vladislav.panfilov@flant.com>
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
Signed-off-by: Vladislav Panfilov <97229646+prismagod@users.noreply.github.com>
Co-authored-by: Dmitry Prytkov <dmitry.prytkov@flant.com>
Co-authored-by: Dmitry Prytkov <74240854+hayer969@users.noreply.github.com>
Co-authored-by: Vladislav Panfilov <vladislav.panfilov@flant.com>
Co-authored-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
Co-authored-by: Vladislav Panfilov <97229646+prismagod@users.noreply.github.com>
(cherry picked from commit 1f4ae4e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants