Skip to content

Conversation

@diafour
Copy link
Member

@diafour diafour commented Oct 14, 2025

Description

Temporarily increase memory limit value to workaround OOMKill during importing huge images ~2.9GiB on linux kernels 6.12+.

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section:
type:
summary:

Temporarily increase memory limit value to workaround OOMKill during importing huge images ~2.9GiB on linux kernels 6.12+.

Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
@diafour diafour requested review from Isteb4k and fl64 as code owners October 14, 2025 15:04
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 14, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Temporarily raised the memory limit for the importer container in the CDI configuration to 3600M to prevent OOMKills when handling large (~2.9GiB) image imports on newer Linux kernels, with a TODO to revert once the root cause is addressed.

File-Level Changes

Change Details Files
Increased memory limit for CDI importer
  • Changed memory limit from 600M to 3600M
  • Added inline comment explaining the temporary workaround and TODO to revert
templates/cdi/config.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@diafour
Copy link
Member Author

diafour commented Oct 14, 2025

Success on new cluster with nodes on linux kernel 6.12+.

@diafour diafour merged commit 64226ed into release-1.0-cse Oct 14, 2025
26 of 29 checks passed
@diafour diafour deleted the chore/core/workaround-increase-memory-limit-for-cdi-importer branch October 14, 2025 17:26
diafour added a commit that referenced this pull request Dec 2, 2025
Temporarily increase memory limit value to workaround OOMKill during importing huge images ~2.9GiB on linux kernels 6.12+.

Port #1573 to upstream.

Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
diafour added a commit that referenced this pull request Dec 4, 2025
Temporarily increase memory limit value to workaround OOMKill during importing huge images ~2.9GiB on linux kernels 6.12+.

Port #1573 to upstream.

Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants