Skip to content

fix(vm): fix migrating if node selector in vmclass was changed #1773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eofff merged 1 commit into from
Dec 1, 2025
Merged

fix(vm): fix migrating if node selector in vmclass was changed #1773

eofff merged 1 commit into from
Dec 1, 2025

Conversation

@eofff
Copy link
Contributor

@eofff eofff commented Nov 28, 2025 •
edited
Loading

Description

If the nodeselector for vmclass has changed, virtual machine migrations with Automatic restart approval mode will not fail.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vm
type: fix
summary: Fix migrating if node selector in vmclass was changed.

fix
492d23f 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Nov 28, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Nov 28, 2025

Workflow has started.
Follow the progress here: Workflow Run

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Nov 28, 2025
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Nov 28, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Nov 28, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Nov 28, 2025
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Nov 30, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Nov 30, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Dec 1, 2025
@eofff eofff changed the title fix fix(vm): fix migrating if node selector in vmclass was changed Dec 1, 2025
@eofff eofff added this to the v1.3.0 milestone Dec 1, 2025
@eofff eofff marked this pull request as ready for review December 1, 2025 08:51
@eofff eofff merged commit eb57556 into main Dec 1, 2025
170 of 193 checks passed
@eofff eofff deleted the fix/vm/do-not-restart-if-node-placement-in-vmc-changed branch December 1, 2025 09:16
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Dec 1, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaroslavborbat yaroslavborbat yaroslavborbat approved these changes

@Isteb4k Isteb4k Awaiting requested review from Isteb4k Isteb4k is a code owner

Assignees

@eofff eofff

Labels

None yet

Projects

None yet

Milestone

v1.3.0

Development

Successfully merging this pull request may close these issues.

4 participants

@eofff @deckhouse-BOaTswain @yaroslavborbat