-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update @SourceStreams and @SinkStreams docs to clarify that they are required #46
Update @SourceStreams and @SinkStreams docs to clarify that they are required #46
Conversation
…required to make streams accessible
LGTM. One additional thing we could do is raising a warning in the annotation processor which creates the META-INF file if there are no streams at all. While it's technically still valid (if a user doesn't want to connect to any Decodable streams at all), I think it should be the exceptional case. So more users would benefit from that build-time warning than would be irritated by a "false" warning. WDYT? |
…eams are declared
65e0efe
to
4bb3da7
Compare
Ok, I tried to change the processor so it always runs and prints a warning when neither sources nor sinks are specified. It now processes all annotations so that it's not skipped entirely if the annotations are not present - but in turn, it doesn't mark the annotations as processed so other processors can process their annotations afterwards. I also fixed a NPE I noticed by chance. |
@gunnarmorling quick ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx!
🎉 This issue has been resolved in |
Resolves #45