Add trailing periods support to FindFirstFileA
#75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed the wildcard assert since the CI test passes a wildcard to |
jpburnett
approved these changes
May 22, 2024
encounter
reviewed
May 27, 2024
| @@ -1368,17 +1379,19 @@ namespace kernel32 { | |||
| } | |||
|
|
|||
| unsigned int WIN_FUNC GetCurrentDirectoryA(unsigned int uSize, char *lpBuffer) { | |||
| DEBUG_LOG("GetCurrentDirectoryA(%u, %p)\n", uSize, lpBuffer); | |||
| DEBUG_LOG("GetCurrentDirectoryA(%u, %p)", uSize, lpBuffer); | |||
There was a problem hiding this comment.
So the debug logs I added get printed in the same line
encounter
reviewed
May 27, 2024
| @@ -32,7 +32,6 @@ namespace files { | |||
| return path; | |||
| } | |||
|
|
|||
| path = path.lexically_normal(); | |||
There was a problem hiding this comment.
This is duplicated, there's another lexically_normal call above. Unless calling it twice is required?
There was a problem hiding this comment.
Oh I see, definitely shouldn’t be required twice. Wonder how it got that way 🤔
encounter
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support to handle directories with trailing periods (ie
include/.) passed toFindFirstFileAand family.I couldn't find docs on how the function should behave in this case (https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-findfirstfilea), but assuming it means "find anything on the passed directory" makes the program happy.
This was needed by "GCC 2.95.3 SN 1.14's
cpp.exe"I also added an assert in
FindFirstFileAto check for wildcards and a few other unrelated logs. I can remove them if preferred.