Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blake kernel optimisation for nvidia cards #24

Merged
merged 1 commit into from
Apr 13, 2016
Merged

Conversation

tpruvot
Copy link

@tpruvot tpruvot commented Mar 24, 2016

part of my tasks in the RFP-5

Signed-off-by: Tanguy Pruvot tanguy.pruvot@gmail.com

part of my tasks in the RFP-5

Signed-off-by: Tanguy Pruvot <tanguy.pruvot@gmail.com>
@jcvernaleo
Copy link
Member

@tpruvot really sorry for taking so long before getting to this PR.
So I can't test or benchmark this myself (no nvidia hardware) but I did go through the code pretty well. Looks good. One question (which I'll put as a separate comment so I can attach it to the right line).

@jcvernaleo
Copy link
Member

Actually, it appears github will not let me do the line by line comment (diff to large maybe?).
Is there a reason that in the code after /* 14 rounds */ you made each round a single line rather than the original code which had each statement on a line? I found the single line with multiple statements much harder to read.

@tpruvot
Copy link
Author

tpruvot commented Apr 12, 2016

no real reason, its how it was done in other blake kernels

@jolan
Copy link

jolan commented Apr 13, 2016

tACK

Mined on testnet with this. 2 blocks on fast AMD hardware before quitting, 2 on Intel, and a couple dozen on Nvidia.

@cjepson
Copy link

cjepson commented Apr 13, 2016

utACK

OK for merge

@jcvernaleo jcvernaleo merged commit 62fd64d into decred:3.7 Apr 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants