blockchain: CheckConnectBlockTemplate with tests. #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
blockchain_checkconnectblocktemplate
branch
10 times, most recently
from
2a8d44a to
87110b2
Compare
|
Rebased to the latest master and resolved conflicts. |
davecgh
force-pushed
the
blockchain_checkconnectblocktemplate
branch
from
87110b2 to
47c1299
Compare
davecgh
changed the title
|
Rebased to the latest master and resolved conflicts. This is ready to merge now. |
davecgh
force-pushed
the
blockchain_checkconnectblocktemplate
branch
from
47c1299 to
d6498a9
Compare
alexlyp
approved these changes
May 3, 2018
This removes the CheckConnectBlock function in favor of a new function named CheckConnectBlockTemplate which more accurately reflects its purpose of testing block template proposals and uses this fact to be more restrictive about the allowed inputs and to avoid performing the proof of work check. In particular, the provided block template must only build from the current tip or its parent or an error is returned. All mining code has been updated to call the new function accordingly. Finally, it also adds a full suite of tests for the new function using the chaingen framework in order to ensure proper functionality.
davecgh
force-pushed
the
blockchain_checkconnectblocktemplate
branch
from
d6498a9 to
6327ed7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires PRs #1076, #1077, #1084, and #1085.(now merged)This removes the
CheckConnectBlockfunction in favor of a new function namedCheckConnectBlockTemplatewhich more accurately reflects its purpose of testing block template proposals and uses this fact to be more restrictive about the allowed inputs and to avoid performing the proof of work check.In particular, the provided block template must only build from the current tip or its parent or an error is returned.
All mining code has been updated to call the new function accordingly.
Finally, it also adds a full suite of tests for the new function using the
chaingenframework in order to ensure proper functionality.