multi: Implement stake difficulty change and vote. #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var err error | ||
| node, err = b.getPrevNodeFromNode(node) | ||
| if err != nil { | ||
| return 0, err |
There was a problem hiding this comment.
Is this right? Or should this be a continue?
There was a problem hiding this comment.
It's correct. The only way this can fail is due to failing to load the node from the database and if that happens something is very wrong and there is no way to continue, so it must error. That is especially critical since this is consensus code, it can't just ignore failure to retrieve the data.
| // | ||
| // This function is safe for concurrent access. | ||
| func sdiffAlgoDeploymentVersion(network wire.CurrencyNet) uint32 { | ||
| if network != wire.MainNet { |
There was a problem hiding this comment.
I find this a bit scary. How do we ensure this gets updated in the future?
There was a problem hiding this comment.
It shouldn't ever need to be updated except to remove it altogether once the agendas are removed.
| state, err := b.deploymentState(curNode, deploymentVersion, | ||
| chaincfg.VoteIDSDiffAlgorithm) | ||
| if err != nil { | ||
| return 0, err |
There was a problem hiding this comment.
Is this right? What happens on the other end of this function? Should this be either a panic or a fallthrough to have some defaults?
| state, err := b.deploymentState(curNode, deploymentVersion, | ||
| chaincfg.VoteIDSDiffAlgorithm) | ||
| if err != nil { | ||
| return 0, err |
dajohi
approved these changes
Apr 26, 2017
| @@ -873,8 +883,7 @@ func (b *BlockChain) CheckBlockStakeSanity(stakeValidationHeight int64, node *bl | |||
| calcSBits, err := b.calcNextRequiredStakeDifficulty(node.parent) | |||
| if err != nil { | |||
| errStr := fmt.Sprintf("couldn't calculate stake difficulty "+ | |||
| "for block node %v: %v", | |||
| node.hash, calcSBits) | |||
| "for block node %v: %v", node.hash, err) | |||
davecgh
force-pushed
the
new_sdiff_algo
branch
5 times, most recently
from
9f183a2 to
8819c0e
Compare
This implements a new stake difficulty algorithm along with a voting
agenda for all networks to change and a comprehensive set of tests. It
also implements estimation using the new algorithm for the
estimatestakediff RPC.
The following is an overview of the changes:
- Add new agenda to vote on changing the stake difficulty algorithm to
all networks
- The version on mainnet is version 4
- The version on testnet and simnet is version 5
- Modifies the stake difficulty calculation function to calculate the
difficulty based on the result of the vote
- Modifies the stake difficulty estimation function to calculate the
difficulty based on the result of the vote
- Makes the stake difficulty estimation function concurrent safe
- Calls it directly from the RPC server instead of going through block
manager
- Removes no longer needed code from the block manager
- Generate new version blocks and reject old version blocks after a
super majority has been reached
- New block version on mainnet is version 4
- New block version on testnet and simnet is version 5
- Add tests for the supply estimation used in the new algorithm
- Add tests for the new algorithm calculations
- Add tests for the estimation based on the new algorithm
marcopeereboom
approved these changes
Apr 26, 2017
alexlyp
approved these changes
Apr 26, 2017
davecgh
added
the
consensus changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a new stake difficulty algorithm along with a voting agenda for all networks to change and a comprehensive set of tests. It also implements estimation using the new algorithm for the
estimatestakediffRPC.The following is an overview of the changes:
Closes #584, closes #592, closes #593, and closes #594.