Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to remove all inline JS, starting with this #841

Closed
chappjc opened this issue Nov 27, 2018 · 1 comment
Closed

Need to remove all inline JS, starting with this #841

chappjc opened this issue Nov 27, 2018 · 1 comment

Comments

@chappjc
Copy link
Member

chappjc commented Nov 27, 2018 •
edited
Loading

dcrdata/views/charts.tmpl

Lines 140 to 142 in db8e600

<script type="text/javascript">
var ticketsPrice = {{.Data}};
</script>

Using Go's html template engine to set JSON data in inline javascript. We need to remove that anyway possible.

Originally posted by @chappjc in #832 (comment)

Ref 1: #463 (review)
Ref 2: #463 (comment)

This facilitates proper CSP: #832
@buck54321 buck54321 mentioned this issue Nov 27, 2018
Closed
9 tasks
@buck54321
Copy link
Member

Closing with #843

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@buck54321 @chappjc