-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: incorrect Build ID displayed (in settings) #3088
Comments
For some additional details from the chat channel where I looked at the code a bit:
Another remark I made in the dex dev channel: I'm curious why it's being done via the HTML and webpack files like that at all. It would be nicer to simply populate the template from Go which can easily get the hash from the runtime/debug info like dcrd and dcrwallet do it. See code to pull it here. |
This is what I find: |
The value is populated here |
I've noticed the Build ID string displayed in UI doesn't seem to match the actual commit it is presumably supposed to reflect, for example for v1.0.2 it shows 1fd2fce (I'm not sure where this value comes from, couldn't find it on Github):
The text was updated successfully, but these errors were encountered: