-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client/eth: Use bytes as string in key import. #1335
Conversation
JoeGruffins
commented
Dec 8, 2021
•
edited
Loading
edited
Could also change Unlock to use the bytes encoded as hex, but other wallets look to just use string(). Also, I believe the simnet contract address is deterministic as long as it's sent from the same account with the same nonce and the same txdata. Not sure about this test failure. Am not seeing locally. Also, need to remove the comments in |
e118d9d
to
d275c56
Compare
I ammended the commit and it's not failing now. Here was the test though https://github.com/decred/dcrdex/runs/4453620451?check_suite_focus=true |
This change is needed because unlocking will use the bytes as a string. Also set the simnet contract address.
aaeba35
to
f34bf24
Compare
I was lucky to hit the 1/256 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In client/asset/driver.go, the definition of CreateWalletParams
should probably have a comment to reduce ambiguity like Pass []byte // utf-8
, but this PR is good.