build: Test against Go 1.20+ and modernize build. #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of go 1.16, "go build" and "go test" now exit with an error rather than silently modifying go.mod or go.sum files. As a result, we don't need to manually check for altered mod/sum files in the test script.
Improve portability of run_tests.sh by using the POSIX compliant shebang for locating bash.
golangci-lint detects when it is running in CI and automatically switches to the appropriate output format, it doesn't need to be done manually.
davecgh
approved these changes
Oct 2, 2023
|
|
||
| steps: | ||
| - name: Set up Go | ||
| uses: actions/setup-go@c4a742cab115ed795e34d4513e2cf7d472deb55f #v3.3.1 | ||
| uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe #4.1.0 |
| with: | ||
| go-version: ${{ matrix.go }} | ||
| - name: Check out source | ||
| uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 #v3.1.0 | ||
| uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 #v4.1.0 |
davecgh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly updates build tooling to more closely match how things are configured in other Decred repos: